Alright, thanks WYE!
Originally posted by 6646Is the cause of this problem caused by the absence of function clearing processing?
I assume so. I suppose asar_patch() just doesn't automatically clean up its mess, though I think the API has a function for manually cleaning up everything?
If that doesn't work, what if you always call asar_close() and asar_init() before calling asar_patch(), does that fix the issue? If not, it's something that's worth looking into.
Originally posted by 6646Invalid pointer error occurs when calling asar_close
That's interesting. I'm not sure if I can currently debug the Linux build on my system (I can build it here, using Bash for Windows 10, but I'm not sure about debugging, haven't looked into that). I could install a Virtual Machine, though. Can anyone else confirm this problem before I do that?
----------------------------------------
So anyways, I've went ahead and just edited the current waiting v1.40 (cause apparently that's a thing that can be done). The URL hack didn't work, but I'll live with it now.
Originally posted by AlcaroOriginally posted by RPG Hackerand I don't want version 1.40 to be lost completely from the version history
I'm not sure why that'd matter.
To a minor degree, for historical preservation, but to a way larger degree, just out of paranoia. I've worked as a professional programmer for just barely two years now, but that time was already more than enough to make me really, really appreciate propper source/version control (you don't want to know how many times this has saved our butts just for Darksiders alone). And with Asar not (officially) being managed under any kind of source control, the version history on SMW Central is basically the "best" alternative we get.
I mean, you should really know what I'm talking about - approximately 25% of the whole Asar source code are just code that was commented out, because, who knows, "we might still need it after all". In fact, while working on those new versions, I removed a good bunch of those lines whereever I was confident that they weren't needed anymore ever again. I personally do not leave any commented out code in any of my commits (except for maybe a few lines or code that's left in for debugging purposes), mainly because it's considered a bad business practice here, but also because I think it makes the code more fragmented and harder to read, so I only ever do temporarily and make sure to remove commented code at some point (when I don't forget to, anyways).
So long story short, I kinda like to see the version history as a "poor man's version control". Though at least for the stuff I added myself, I actually do have some degree of source control, since I actually used a private GitHub repository while implementing all of those new features. It would actually be good to have an official SMW Central GitHub repository or something like that where all of the source code of tools and stuff could officially be hosted so that people could just fork it and contribute to it. Having all of the source code in just the upload itself is "kinda okay", but nowadays, there are simply better and more reassuring alternatives.
Feel free to visit my website/blog - it's updated rarely, but it looks pretty cool!