Aaaaaaaah so many bugs. I've fixed around half of the ones reported so far (including some sent via PM), and once I've fixed them all I'll resubmit the tool. Thanks for reporting them, and I'm sorry they, well, exist.
Originally posted by ArchieEdit: I think there is a bug on there. I inserted a starman music for my hack, and when I touch the star, after I die, the music keeps on playing, and the overworld has the music of the level that I choose instead of the overworld music. Also, is it intentional that the P-switch music plays when I push the P-switch while on starman effect?
Found the bug; fixed it. Thank you.
Originally posted by imameliaOkay, this is weird...when I touch the goal in Yoshi's Island 3, the victory music doesn't play, and then all the other music has a greatly slower tempo until I die, at which point it goes back to normal. I don't know if this is the fault of AddmusicK or my port, but it's something that I'd like to fix.
I can't seem to reproduce it. Can you give me more information?
Originally posted by imameliaAlso, is it just me, or is the h command kind of screwy? I know it's not as necessary now that we have the pitch submultiplier, but I'm trying to convert an older port, and it seems to modify the notes even outside of the current channel.
...aaand now one of my instruments is detuned (about a whole step too low) on one channel but not another. What...
I was never quite able to figure out exactly how that command worked; up until now though it seemed to be fine for existing ports. How exactly does it work (does it only affect the current instrument, only affect the current channel, only affect up until the next instrument is defined, etc)?
Originally posted by DiscoManBy the way, I think there's a bug involving musics that use echo, while I can play the P-switch theme normally in "Here We Go" normally, when I'm in cave and I try to play the theme, SPC crashes.
It happens when I try to upload a music that uses echo too.
Fixed; thanks. (This should fix all instances of the starman and p-switch songs crashing, so I'm only mentioning it from this one post so I don't repeat myself a dozen times)
Originally posted by GravSo, my friend and I were testing out an RS3 song, but to my surprise the $FA $XX oscillation command was removed. However, I noticed $F4 $04 was free. Wouldn't it be possible to make that the command for the oscillation?
(Also, my friend and I can't get any sample that sounds like the oscillation feature, either.)
EDIT: Also bring back the SRCN09 calling, aka the built-in square wave in AMM. The two commands for oscillation were made to work with this built-in sample, so it'd be awesome if you would bring that back, too.
Ha, I was kind of hoping no one used that command...
Alright, I'll see what I can do then.
Originally posted by imameliaAlso, is it normal for AMK ports to be anywhere from 90 to 500 bytes bigger than the same port done in Addmusic 4.05? I don't know why there would be that much of a difference, unless the actual names of the .brr files are assembled into the ROM or something.
I think it's due to this:
Originally posted by Lui37Ahem, possible bug report time (unless you somehow changed how it works ?_?):
while diving through song data in ARAM (don't ask lol), I found out that note commands aren't compressed and instead each note always redefines its note length, even when using the same one as the previous note(s).
As an example, let's take a bar from the SMW underwater music:
Originally posted by 12 Water.txt@3 q79
r4.o5c32d32f32a32>c4r4.<d32f32g32a+32>d4
Originally posted by ARAMDA 03 48 79 C7 06 B0 06 B2 06 B5 06 B9 30 BC 48 C7 06 B2 06 B5 06 B7 06 BA 30 BE
Those notes I highlighted in blue, are using the same note length, but it's redefined each time. Compressed, it would look like this:
Originally posted by me right nowDA 03 48 79 C7 06 B0 B2 B5 B9 30 BC 48 C7 06 B2 B5 B7 BA 30 BE
I very much think that's what's causing
this issue.
Well yeah, not much else to say. I guess that shouldn't be hard to fix.
Also, hooray for funky colours!
...which I'll get on fixing; thanks.
Originally posted by imameliaOh, yeah, I forgot...did you ever allow it to work/make sure that it works on 8MB SA-1 ROMs? I imagine SuperFX ROMs wouldn't require anything extra.
Not yet. I think the only thing that needs changing is the SNESToPC and PCToSNES address conversion functions, though (and a way to tell if a ROM is a 6 or 8 MB SA-1 ROM). It's on my "to do very soon" list, though taking care of these bugs takes priority right now.
Originally posted by aterraformerI would like to let everyone know that AddmusicK acts weird with KilloZapit SMB2 Health Patch and Demonsul Always Small Patch. When patched before adding music, the hack crashes upon Mario's death. When patched after, it changes the death music to Bonus End. If I played around with it I'm sure I could make it work correctly but just as a percussion so you don't break your hack (once it starts crashing it's done!)
Also when I using a 4.05 sample song, the death music changes a little though I have only tried Masashi27's Super Bonk - Twilight Space.
Hope this helps! Beyond that it works great!
I'm not sure how AMK could be causing a crash that happens before you use it (since you can't use it without inserting music), though as mentioned, the song order needed to be changed a bit for certain features to work correctly, so certain values here and there in custom sprites and such might need a bit of adjusting. And as for the death music changing, do you just mean the piano sounding a bit different? Because that's normal and there's not much I can do about it.
Originally posted by aterraformerhahaha Someone else please try inserting Slash Man's old port of Wind Man from Mega Man 6. The results are hilarious. You can find it in the Legacy hack thread here.
http://www.smwcentral.net/?p=viewthread&t=53444
A lot of the old ports do work fine however.
Literally nothing I can do about that, I'm afraid. That port uses an invalid FIR filter that pulls garbage data, so it was doomed to fail on anything other than the Addmusic it was designed for.
Originally posted by Zeldara109Just wondering, does this fix the glitch previous addmusics have, where if the music has sped up due to the timer reaching 99, loading a sublevel with different music (or even the same music, if it restarts due to a P-switch/star) resets it to its original speed?
It should.
Originally posted by MrCheezeI think there should probably be some sort of built-in feature to change what music plays in specific circumstances, because right now (without manual hex editing) you get the same music played from dying and from the credits, for example.
That's a good point, actually. I can't completely fix it (since the original SMW credits music has yet to be ripped), but I can add a way to make it easier to fix.
Originally posted by MrCheezeOh, and one more thing: previous Addmusics seem to have had support for playing percussion instruments at arbitrary pitches like any other instrument, but AddmusicK does not. See
this song for a comparison between the two (just the first couple seconds).
Semi-intentional. Percussion on channels #6 and #7 are forced to play at only their original pitch to avoid glitches. Percussion on any other channel can have any pitch, however. I'm not sure if there's an easy fix for this, but I'll look into it.
Originally posted by imameliaAlso, there seems to be something screwy with label loops. I have one port where channel #0 contains and defines a label loop, and channel #1 starts with that same label. The portion of channel #1 that is covered by that label has a volume of 0. The notes still seem to play, the pitches change, but it is silent.
Edit:
Text file. See the beginning of #1.
Bizarre; I'll look into it. Incidentally, do you know if this occurs in any other Addmusic?
Originally posted by AlcaroI decided to try compiling AM405Remover on Linux, mainly because I didn't think "makefile" would be found (the standard name is "Makefile"). While that worked fine, I ran into a couple of other issues.
First, targetver.h refered to the Windows-only file SDKDDKVer.h. I commented it out.
Second, stdafx.h wanted tchar.h. I purged the entire stdafx.h.
Third, AM405Remover.cpp mentioned _TCHAR. I replaced that with char, and renamed the function to main (_tmain is some more Windows-only shenanigans).
Fourth, the main function is blank, and the resulting program (rather predictably) does nothing.
Fifth, the function removeAM405Data looks like a main - and calls itself Unofficial Addmusic 4.04. (I didn't bother testing what it does; I don't have any Addmusiced ROMs.)
What exactly is going on around there?
AM405Remover should actually be compiled with AddmusicK. They're separated from each other because AM405Remover is literally Addmusic 4.05 but with all music compilation and insertion functions removed. AddmusicK, if it detects a ROM with AM 4.05 on it, sets up AM05Remover like its own sub program and then runs that. I think I accidentally included a couple of bogus files with it by accident, though (main obviously shouldn't be there; neither should stdafx.h or tchar.h). So yeah, that's the explanation behind that weirdness.
Originally posted by AdamMy music seems to break whenever the clapping chuck's sound effect is played,
Could you give me the music in question?
Originally posted by Adamand it seems like when transitioning from submap to submap or submap to overworld, there is a considerable amount of lag.
That's the game loading whatever song that map uses. It's a slow process, since songs are no longer grouped into "overworld" and "level" (which frees up considerable amounts of space in ARAM).
Originally posted by AdamI also noticed that you cant button mash your way through the title screen anymore, and it responds slower to button presses.
Are you absolutely sure that's AMK? I'm almost sure that the only code related to the title screen that the program touches is just the music it plays. If it is AMK I'll definitely have to investigate.
Originally posted by S.C.O.R.P.I.O.N.Question: "Do I use the AddmusicKGUI that's in there to insert music, or the .exe?"
Whichever you find easier to use.
Originally posted by S.C.O.R.P.I.O.N.I used the "AddmusicK.exe" on both my hacked rom and a clean rom, and the music is not even being registered, and .msc file is not being created. Is it supposed to automatically close out after the insertion is complete?
Is it modifying your ROM? Because if so then that is a legitimate glitch. And it is supposed to automatically close if no errors were detected. If you need it to stay open, then launch it without dragging your ROM over it (or without any command line arguments).
And thank you for the comments, everyone! I do appreciate it, and I'll try to fix these bugs as soon as possible. Also, for those who didn't see it in the beta release thread, I'm always going to do my absolute best to make different releases compatible with one another, so you should never need to start back at a clean ROM.