File Name: | Nintendo Presents Logo HDMA v1.2 |
Submitted: | 17 October 2017 - 05:02:45 AM by benjausen |
Obsoletes: | Nintendo Presents Logo HDMA v1.2 |
Authors: | Level ASMer |
Tool: | Asar |
Requires Free Space: | Yes |
Bug Fix: | No |
Featured: | No |
Description: | This patch will add HDMA gradient the Nintendo Presents Logo. And fixed ASM code. Sorry Credit to Ersanio for the original idea, even though I didn't copy his code. Added SA-1 support. |
Originally posted by Submission Notes
just added sa-1 support and nothing else.
This is not properly converted to a hybrid. The Nintendo Presents logo makes no sound on SA-1 due to line 58, where you add $7000 to $1DFC, which results in $8DFC, a ROM address. The proper procedure for any address above $00FF is to add, or OR with, $6000. And that brings me to my second point - when converting a resource to a hybrid, it's better to use a bitwise OR instead of addition, which makes it work even after erroneously being put through a converter tool by a user.
Seeing as the whole purpose of the update is to add SA-1 compatibility, there is no point in fixing this one myself.
On an unrelated note, this patch doesn't work with AddmusicK because both hijack $0093C0. If possible, you should consider changing the hijack of the patch to make it easier to use with AddmusicK (currently, one would have to modify AddmusicK's tweaks.asm).